For me it's the best plugin ever for visual studio. It's the fastest way of navigating. Just one suggestion: I think it would be nice if Ctrl+RightClick on a keyword triggered the search for references of a function.
I agree with most of these reviews - this extension is a must. However I there is so much more potential here which would leave me baffled if the author doesn't explore the possibility of augmenting this:
a) allow for another key combo + left click perform a peek definition b) allow for another key combo + left click perform a find all references
If these are exposed via the API (and I believe they are), adding these features should be fairly trivial.
Sending a different command would be pretty easy to add, yup. If you want it to be configurable, that's more difficult, but just hardcoding combinations wouldn't be bad.
If you're curious about implementing it yourself, the source is here: https://github.com/noahric/gotodef. The actual command logic is in DispatchGoToDef in GoToDefMouseHandler.cs, so you could probably modify that function (or add new functions) for peek or find all references. Since the extension is still built to be compatible with VS2010, you'd want to hardcode the cmdset/cmdid for peek definition and do a version check first, though.
If you have any questions, let me know on the Q&A!
Works with VS 2013. It just requires some manual work: 1. Download the .vsix file 2. Unzip it (e.g. using 7zip) 3. Open the vsixmanifest file and add the following block to line 22 <VisualStudio Version="12.0"> <Edition>Pro</Edition> </VisualStudio> 4. Save and Zip all files again 5. Rename the .zip to .vsix and install it
Sadly, there wasn't a non-hacky way to implement the extension, and there's no way to determine which languages "support this feature natively". Since Go To Definition wasn't designed as a queryable command, the extension had to use some broad guessing at what has definitions, and it actually under guesses for certain scenarios (I remember one or two in VB, at least).
I'd be happy to at least modify this standalone version to avoid loading for documents that use your DSL language type and you could file a Connect bug to get it integrated back into the PPT extension . Fee free to either add a Q&A comment here or a github bug (https://github.com/noahric/gotodef/issues) with the details, or make the modifications yourself and send me a pull request on github.
I believe there is a bug in implementation which causes this extension to conflict with word select functionality of the editor - i.e. when CTRL is pressed, mouse selection is automatically extended to words. I guess operator "&&" should be replaced by "||" in this method
private bool InDragOperation(Point anchorPoint, Point currentPoint)
// If the mouse up is more than a drag away from the mouse down, this is a drag
return Math.Abs(anchorPoint.X - currentPoint.X) >= SystemParameters.MinimumHorizontalDragDistance &&
Math.Abs(anchorPoint.Y - currentPoint.Y) >= SystemParameters.MinimumVerticalDragDistance;
i.e. current code detects only 'diagonal' drags, but it should work if drag is done along X or Y axis too.
Thanks for this extension, BTW :).
Looks like a bug indeed :) Funny thing is that I'm pretty sure that code looks nearly identical to the drag/drop mouse handler built in to VS. I'll update the code shortly (and the extension at some point after that; that may take a little while). Thanks!
I am using Resharper, which provides Go To Implementation in the context menu, which is very useful, as we use interfaces heavily.
I'd love to be able to override the Ctrl+Click behaviour to go to the implementation instead, which is far more common usage than going to the interface. I suspect you might not be able to pull it off though if it's only built into Resharper?
Assuming they register it as a command, you could modify the extension to call that command in DispatchGoToDef:
Guid cmdGroup = VSConstants.GUID_VSStandardCommandSet97;
int hr = _commandTarget.Exec(ref cmdGroup,
Some of the Productivity Power Tools extension for VS2010 are already included in VS11, but Ctrl+Click is not one of them.
How hard would it be for you to have your "Go To Definition" extension also target VS11 Beta?
You can do it yourself.
1. Download this extension.
2. Rename GoToDef.vsix to GoToDef.zip
3. Extract all the files in GoToDef.zip
4. Open up the extension.vsixmanifest
5. Change the <VisualStudio Version="10.0"> to <VisualStudio Version="11.0">
7. Zip all the files (GoToDef.zip)
8. Rename the GoToDef.zip to GoToDef.vsix
9. Install the vsix
Overriding the GoToDefinition command behavior is orthogonal to this extension. If you want an example of how to write a command handler, take a look at the FixCtrlBackspace source here: https://github.com/NoahRic/Random/blob/master/FixCtrlBackspace.cs
When press Ctrl + Click, this will jump to the method's definition, this is very helpful.
I am very appreciate if you can add "Jump back" function to this addin (like Shift + click method's name).
Thanks in advance.
Yeah, that is feedback I've heard before :) I'm not really open to the idea of changing the default, but I am open (in principle) to adding an option to change the modifier. That's a large enough bit of work that I haven't gotten around to it yet, though, and probably won't in the near future.
Your best bet is to build the extension yourself. You can grab the source on:
You'll want to modify GoToDefMouseHandler.cs to replace the two instances of ModifierKeys.Control with ModifierKeys.Shift. That *should* be all that's needed, though there very well may be issues you run into with the new shortcut conflicting with other mouse gestures.
(Also, to build the extension, you'll need the VS2010 SDK installed).
If you try to build it yourself and have any issues, let me know. I'll try to help as best I can :)
Is there any method to set the modifier which trigger the go-to-definition feature?
I am used to hold the Ctrl to select multiple words as a whole. This behavior conflicts with the functionality of this extension.
A selection check before triggering is fine for me.
Thanks Mason, that's an item to put on the backlog. I'm mulling over how to expose it, as putting a single options page somewhere in Tools->Options just to select some combination of alt/ctrl/shift seems overkill, but there isn't really another common location to put that option. If you have any ideas, that would be helpful, too :)
I would really like to use this extension but I do not want to "sacrifice" my Ctrl DblClick.
The trigger customization is something that I consider as an enormous benefit for this expansion. I am even absolutely fine with specifying the trigger key manually in the .config file.
Do you use ctrl-click or just double-click? They do the same thing, and this extension (should) only affect the former. If you are used to double-clicking to select a word, then you just need to un-train yourself to hold down control when you do it.
I'll keep the .config option in mind. Also, if you are up for it, you could try grabbing the source (http://github.com/NoahRic/GoToDef) to change it yourself. It's unfortunately not well factored to make it a completely trivial change, but it should be about as easy as replacing all instances of ModifierKeys.Control with ModifierKeys.Alt.
Version 2.1 worked better for me. The new version does not react as I aspect. Clicking first Ctrl and then perform a mouse click does not work any more.. Now it reacts sometimes if a perform a mouse click first and then press ctrl. Is there a possibilty to get the version 2.1.
Hey Chris, I'm not quite sure what you mean :( I generally use it by holding down the ctrl key and then clicking, which is what it sounds like you are saying doesn't work. Could you give me a bit more information on what isn't working?
To get version 2.1, you can download the source at that point (http://github.com/NoahRic/GoToDef/zipball/2.1) and build it yourself, once you've downloaded the SDK.
exactly that is what doesn't work. I'll give you some scenarios and what then is happen.
1. Holding down ctrl and then moving the mouse to the word --> Nothing is happen
2. Moving first to the word then holding down ctrl --> Color of the word is changing and the word is underlined, mouse pointer is sometimes changed
3. Moving the mouse after 2. --> Mouse pointer is rechanged and will never changed back, word is sometimes still blue and underlined
4. Clicking after 2. --> Nothing is happen
5. Moving first to the word then clicking and holding the mouse button down and then holding the ctrl key and finally release the mouse button --> Performs as I expected on 4.
Since version 2.1 works fine for me, I will use this version again.
Do you have any other extensions installed (like the pro power tools)? It's possible there could be something conflicting there. I still can't repro it, so there isn't much I can do to fix it for you, sorry :(
There are some other extensions in the extension manager:
- DevExpress Tools
- Enterprise Library v5 Configuration Editor
- Go To Definition
- Highlight all occurrences of selected word
- PowerCommands for Visual Studio 2010
- Regex Editor
- Visual Studio 2010 Pro Power Tools
But I find a solution so I'm happy again :-)
I'm not sure what else it is, then :-/ It could be an interaction with the DX tools or Nick's highlight references extension (I didn't realize earlier that you had that extension installed; when I saw "highlight references", I assumed the built-in feature). Unfortunately, the only ones I have source for are the pro tools (since it is a copy of this extension) and the regex editor. While the regex editor's implementation of mouse handling is suspicious, it shouldn't be causing a problem except on lines that have "new Regex(".
Noah, this is workaround and it decreases usability of the extension. Try copy with mouse hyperlink
in winword. It's the right behavior. Need to change your mind every time new extension appears is wrong.
The fix I've suggested (just do not navigate on click on selection) is simple. Why not implement it?
The fixes you suggested are not simple in this context, unfortunately. I may try moving the logic back to handling mouse up events and deal with the other issues that crop up (as the extension worked when I first wrote it), but it isn't a simple change. In the editor, mouse interaction is handled in a decentralized and often hard-to-debug manner, which is what makes this complicated in the first place.
If you'd like, you can download the source and make the change on a private version of the extension you are running; the source can be found on github here: http://github.com/noahric/gotodef. If it really is as simple as you say, it should be easy for you to fix.
In the meantime, if I get some time this weekend I'll take a look at fixing this.
Sorry, forgot to add: the hard part of the fixes you mentioned ("fix it", and "add an option") are the mouse interaction for the first part (as I describe in my previous post) and adding an option page (involves adding a package options page some hackery for WPF options pages). Just changing it to not navigate when clicking on the selection wouldn't be difficult, but I don't think that's the right default behavior. However, it should be pretty easy to make that change in a private copy and run that on your own machine.
May be it'll best to align with all links/buttons behavior and navigate on mouse up.
However, there is cludge (done in 5 mins; not debugged yet but seems to work).
Just one line:
// Now, check for valid classification type. C# and C (at least) classify the things we are interested
// in as either "identifier" or "user types" (though "identifier" will yield some false positives). VB, unfortunately,
// doesn't classify identifiers.
foreach (var classification in _aggregator.GetClassificationSpans(extent.Span))
var name = classification.ClassificationType.Classification.ToLower();
if ((name.Contains("identifier") || name.Contains("user types"))
Yeah, as I said in my last post, though, I don't want to make that change by default ("Just changing it to not navigate when clicking on the selection wouldn't be difficult, but I don't think that's the right default behavior.") The hard part is fixing it without introducing that behavior or introducing that behavior as an option.
Bob, the right design is to align behavior with common rule: buttons and links are clicked on mouse up. After that, it's quite simple to ensure that mouse moved out of drag-drop threshold and do not navigate.
Here is what I get when the extension is installed:
Highlight the element.
Hold control key down (underlines).
Mouse-down on the highlighted/underlined text.
Goes right to definition (does not wait for mouse up).
When the extension is not installed, BTW, I am not able to copy drag anyway. Holding the control key down simply extends the highlighting when the mouse is clicked and dragged. Is this a bug or a "feature" in 2010???
Bob, when I said "the right design..." i meant "how things should be done". Sorry if mislead you.
Confirmed - when extension disabled or uninstalled, ctrl should be pressed after mouse key. "Feature", I think.
Bob - it didn't change in VS2010, though this extension conflicted with it.
Bob and Sinix - could you guys give 2.2 a try, if you are still interested in using the extension? I've updated it to work with mouse up and worked around some of the original issues I ran into, so this should now work more sensibly with word selection and drag/drop.