I installed the Code Review Policy on a local server, and every time a client attempts to make changes they receive the following error
"Internal error in Code Review Policy. Error loading the Code Review Policy policy (The policy assembly 'ColinsALMCheckinPolicies.CodeReviewPolicy, Version=22.214.171.124, Culture=neutral, PublicKeyToken=null" is not registered.)"
I have tried adding the .dll to both the PrivateAssemblies and PublicAssemblies directories on the server, but still no success.
Are there any additional steps required to use this extension (i.e, installing the extension on all client PCs, adding the assembly to the global assembly cache, etc..)?
Any help would be appreciated.
I installed the 2013 version.
The process work fine , but when I try to Check-In the code I always get this message:
"Please request a code review for this changeset before attempting check-in..."
You can ignore my question. After installing on a test environment, I found that change was done at the TFS server which was available to all users. I also saw that it would be applicable to specified paths.
By the way, this will address an important requirement for us.
I have noticed that if I submit a code review to someone. Then make additional edits, including files not in the original review request. The Reviewer then marks the code as "Looks Good", during which they only saw the changes from the original request. My "Check-In" is allowed, with the new edits, basically getting the new edits to bypass a code review.
Is the source code available for this extension or could it be modified to check the file counts from the original request before allowing the check in?
I see the problem. Unfortunately this is a limitation in the current Code Review mechanism, since your pending changes can be edited while the review is ongoing. I don't think there's a way to detect that the pending changes have changed after the code review request.
Go to Team Explorer and connect to your Team Project. Use the dropdown at the top to go to Settings. Under the Team Project settings, click on Source Control. Then go to the Check-in Policy tab. Click the add button to add the policy. It should pop up the configuration immediately. You can always click Edit to change the settings at a later stage.
Wouldn't be great if some "advanced users" (eg. Experienced developers) could override this policy?
I mean, would be great if only a TFS Group members are subject to this policy (commonly new developers).
Thanks for the comments! I considered long and hard about doing this based on "user group", but decided that doing it on the "source path" is probably a better way to go. Now you can allow checkins to DEV branches, and enable the policy on MAIN or LIVE branches.