There is a bit of trial and error to get the steps to submit the code review right but overall it has been a great tool.
One of the key things to be aware of is to make sure you close your Code Review Requests before attempting to do your check in. Closing the Code Request Response with Looks Good, Needs Work or With Comments does not automatically close the Code Review Request
We have created custom code check-in policy similar to yours. It is working fine except the fact that after getting positive response from the reviewer if user changes the code and then checks in, it is allowing to check in. Because the code is changed after the review was done, it should require another code review. This way users can bypass the mandatory code review policy
Can you please give an idea on how to handle this? This is very important as we are implementing the mandatory code review policy;will appreciate you assistance on this.
We've installed the Plugin and the tool seems to work as designed, except we're having an issue with the following scenario:
1. We have the tool set up to with the following options:
a. Required Review to be Closed - checked
b. Fail if any response is 'Needs Work' - checked
c. Min Pass Level: Looks good
2. We initiate a TFS code review and a reviewer sets it to 'Needs Work'.
3. Warning is issued when trying to checkin the file as expected.
4. Initial developer (who sent out code review) fixes problem as per code review and initiates new code review (there's no way to re-issue the original code review request).
5. 2nd code review comes back as 'Looks Good' and is Closed.
6. When trying to check file in, warning is still issued.
7. Tried closing initial Code Review, but warning is still issued.
My guess is the Initial Code Review is still tagged as 'Needs Work' and that's why the policy is firing the warning. However I see no way to change the Initial code reviews comments (i.e. to 'Looks Good').
Yes, looks like wit needs to be removed/unlinked as per another comment the other vs 2013 discussion thread. obviously that doesn't seem like a good approach. the approach would be to allow check in if any subsequent wits are 'good'. I think this will take custom editing the template itself.
Had the same issue, it turned out that you must close all of the Code Review Requests associated with the pending check-in before attempting to submit your check-in. When you close a Code Review Response with Needs Work, Looks Good or With Comments, the Request remains in Requested status.
I´m having a similar issue. Developer assign Code Review. Code Review is approved(Looks Good) and Developer try to do Check-In and VS shows the error about Code Review Policy. This error appears even before doing Code Review (when creating a Shelve.
Is someone else having this issue? Any fix around this? Is there something that I´m doing wrong?
The extension is working great except that applying the policy to a sub-project path doesn't seem to work right (using Visual Studio 2013).
We've added only a path that is below our main project path; however, all check-ins for all of the project's paths require a code review now. It caused quite a stir (lol) when other teams suddenly got prompted for code review (and wasn't necessarily a bad thing).
Is someone else able to repro this issue?
Hi, i am looking into using this extension, and i would have the same issues regarding projects. have you solved this? does it work on sub-projects only? and does every developer need to install this on their local machine for this to work? or can it be done server side, requiring this 'check-in' to occur. tx
Hey there, I've recently added in the extension, tried to isolate the policy to a directory and other users reported the same issue you've been having.
What I found was once the extension was installed on a users machine the path filter now worked as expected.
So, for now, it appears you need ever user of a project to have the extension installed.
Hi Colin, this is a great tool. My question is where should I install this tool. Does it need to be install in the TFS App tier servers or it needs to be installed in individual machine?
As a TFS admin if I install it in my machine and apply the Check-in policy will it be universal or individual user(developer) need to install it as well?
Hi ,amybe some can help me. When I click on Actions/Request Review I got this error "Work item type Code Review Response is missing field Microsoft.VSTS.CodeReview.ClosedStatusCode"
It worked very well before with TFS2012. Since then we migrated to TFS2013. I tried to upgrade the extension to version 1.3 Then downgrade to 1.2. Still the same error.
I found that even I set the "Min Pass Level" to "With Comments" or "Looks Good", I still can not pass the policy check. I'm using non-US version of VS2013 (actually is "Traditional Chinese"), so any idea for this problem?
Exactly the same problem here. I guess it has something todo with the language because we use a german version of tfs and we have the same problem like you. Any idea? Does this plugin just work with an english version of TFS?
I installed the extension in VS2013 Ultimate and connected to VSO. When I try to add a the code review as a check-in policy the dialog displays but I can't edit the source path test area and there is no way to close the dialog. Is there something I am missing like a specific version of VS2013 i.e. update 2 or 3? Any help on this is greatly appreciated.
I'm trying to start using this policy, but it failed the first test.
1- Developer D requests review for file F1
2- Reviewer closes request as Looks Good
3- D adds a new file F2 along F1 and tries to check-in
4- Checkin succeed
The files being checked-in are linked to the review for the validation?
This policy is very helpful and I'm looking forward to start using it.